aboutsummaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
authorEgor Tensin <Egor.Tensin@gmail.com>2023-08-27 11:31:45 +0200
committerEgor Tensin <Egor.Tensin@gmail.com>2023-08-27 11:32:58 +0200
commitcebe9a8f5d8bc5ff840a224ffe02ce0c91c06ec3 (patch)
treeaec2ae786f9e9df1cddbe5369054a6a58b5e1c73
parentadd DEVELOPMENT.md (diff)
downloadcimple-cebe9a8f5d8bc5ff840a224ffe02ce0c91c06ec3.tar.gz
cimple-cebe9a8f5d8bc5ff840a224ffe02ce0c91c06ec3.zip
make test/perf -> make flame_graphs
Diffstat (limited to '')
-rw-r--r--.github/workflows/ci.yml2
-rw-r--r--DEVELOPMENT.md2
-rw-r--r--Makefile22
-rw-r--r--test/CMakeLists.txt2
4 files changed, 14 insertions, 14 deletions
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 40db76a..380ef74 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -87,7 +87,7 @@ jobs:
# sudo is used to resolve kernel symbols. Plus, it would be required
# if we didn't fix perf_event_paranoid. PATH needs to be preserved
# for FlameGraph.
- sudo --preserve-env=PATH make test/perf
+ sudo --preserve-env=PATH make flame_graphs
mkdir -p /tmp/out/
cp -r ./build/flame_graphs/ /tmp/out/
- name: Upload flame graphs
diff --git a/DEVELOPMENT.md b/DEVELOPMENT.md
index 07c65a7..4a54fea 100644
--- a/DEVELOPMENT.md
+++ b/DEVELOPMENT.md
@@ -32,7 +32,7 @@ https://egor-tensin.github.io/cimple/coverage/.
Some performance analysis can be done by looking at flame graphs.
Generate them after building the project (depends on `perf` & [FlameGraph]):
- make test/perf
+ make flame_graphs
[FlameGraph]: https://github.com/brendangregg/FlameGraph
diff --git a/Makefile b/Makefile
index 79221d6..c2870dd 100644
--- a/Makefile
+++ b/Makefile
@@ -77,14 +77,6 @@ test/sanity:
ctest --test-dir '$(call escape,$(cmake_dir))' \
--verbose --tests-regex python_tests_sanity
-.PHONY: test/valgrind
-test/valgrind:
- @echo -----------------------------------------------------------------
- @echo Running sanity tests w/ Valgrind
- @echo -----------------------------------------------------------------
- ctest --test-dir '$(call escape,$(cmake_dir))' \
- --verbose --tests-regex python_tests_valgrind
-
.PHONY: test/stress
test/stress:
@echo -----------------------------------------------------------------
@@ -93,13 +85,21 @@ test/stress:
ctest --test-dir '$(call escape,$(cmake_dir))' \
--verbose --tests-regex python_tests_stress
-.PHONY: test/perf
-test/perf:
+.PHONY: test/valgrind
+test/valgrind:
+ @echo -----------------------------------------------------------------
+ @echo Running sanity tests w/ Valgrind
+ @echo -----------------------------------------------------------------
+ ctest --test-dir '$(call escape,$(cmake_dir))' \
+ --verbose --tests-regex python_tests_valgrind
+
+.PHONY: flame_graphs
+flame_graphs:
@echo -----------------------------------------------------------------
@echo Collecting profiling data
@echo -----------------------------------------------------------------
ctest --test-dir '$(call escape,$(cmake_dir))' \
- --verbose --tests-regex python_tests_perf
+ --verbose --tests-regex python_tests_flame_graphs
.PHONY: test/docker
test/docker: test/sanity
diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
index 6ae03e6..1470b3c 100644
--- a/test/CMakeLists.txt
+++ b/test/CMakeLists.txt
@@ -34,7 +34,7 @@ if(NOT DEFINED FLAME_GRAPHS_DIR)
set(FLAME_GRAPHS_DIR "${CMAKE_CURRENT_SOURCE_DIR}")
endif()
-add_python_tests(python_tests_perf
+add_python_tests(python_tests_flame_graphs
Python3::Interpreter -m pytest ${python_test_args} -m "flame_graph"
--flamegraph "${CMAKE_CURRENT_SOURCE_DIR}/../scripts/flamegraph.sh"
--flame-graphs-dir "${FLAME_GRAPHS_DIR}")