diff options
author | Egor Tensin <Egor.Tensin@gmail.com> | 2022-08-28 15:14:07 +0200 |
---|---|---|
committer | Egor Tensin <Egor.Tensin@gmail.com> | 2022-08-28 15:14:07 +0200 |
commit | 0ff63a9ceff4c8fcd679b52cb1c03d96675f52f0 (patch) | |
tree | 2b0d1fb32b09988f652228a40508dbcef9c1032e /src/msg.h | |
parent | net: use MSG_NOSIGNAL (diff) | |
download | cimple-0ff63a9ceff4c8fcd679b52cb1c03d96675f52f0.tar.gz cimple-0ff63a9ceff4c8fcd679b52cb1c03d96675f52f0.zip |
holy crap, it actually kinda works now
Previously, I had a stupid system where I would create a thread after
every accept(), and put worker descriptors in a queue. A special
"scheduler" thread would then pick them out, and give out jobs to
complete.
The problem was, of course, I couldn't conveniently poll job status from
workers. I thought about using poll(), but that turned out to be a
horribly complicated API. How do I deal with partial reads, for example?
I don't honestly know.
Then it hit me that I could just use the threads that handle accept()ed
connections as "worker threads", which would synchronously schedule jobs
and wait for them to complete. This solves every problem and removes the
need for a lot of inter-thread synchronization magic. It even works now,
holy crap! You can launch and terminate workers at will, and they will
pick up new jobs automatically.
As a side not, msg_recv_and_handle turned out to be too limiting and
complicated for me, so I got rid of that, and do normal
msg_recv/msg_send calls.
Diffstat (limited to '')
-rw-r--r-- | src/msg.h | 12 |
1 files changed, 8 insertions, 4 deletions
@@ -6,6 +6,12 @@ struct msg { char **argv; }; +void msg_success(struct msg *); +void msg_error(struct msg *); + +int msg_is_success(const struct msg *); +int msg_is_error(const struct msg *); + struct msg *msg_copy(const struct msg *); void msg_free(const struct msg *); @@ -14,10 +20,8 @@ int msg_from_argv(struct msg *, char **argv); int msg_recv(int fd, struct msg *); int msg_send(int fd, const struct msg *); -typedef int (*msg_handler)(const struct msg *, void *arg); -int msg_send_and_wait(int fd, const struct msg *, int *result); -int msg_recv_and_handle(int fd, msg_handler, void *arg); +int msg_send_and_wait(int fd, const struct msg *, struct msg *response); -int msg_dump_unknown(const struct msg *); +void msg_dump(const struct msg *); #endif |