aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/src/command.c (unfollow)
Commit message (Collapse)Author
2023-07-05command: dedupe the codeEgor Tensin
2023-06-13event_loop: add event_loop_add_onceEgor Tensin
2023-06-13sanitize #include-sEgor Tensin
2023-06-13event_loop: hide the API detailsEgor Tensin
2023-06-13use signalfd to stop on SIGTERMEgor Tensin
Is this an overkill? I don't know. The thing is, correctly intercepting SIGTERM (also SIGINT, etc.) is incredibly tricky. For example, before this commit, my I/O loops in server.c and worker.c were inherently racy. This was immediately obvious if you tried to run the tests. The tests (especially the Valgrind flavour) would run a worker, wait until it prints a "Waiting for a new command" line, and try to kill it using SIGTERM. The problem is, the global_stop_flag check could have already been executed by the worker, and it would hang forever in recv(). The solution seems to be to use signalfd and select()/poll(). I've never used either before, but it seems to work well enough - at least the very same tests pass and don't hang now.
2023-06-12command: fix a race conditionEgor Tensin
Modifying cmd_dispatcher fields like that make it inherently unsafe to call cmd_dispatcher_handle_conn concurrently.
2023-05-15msg: strings, not wordsEgor Tensin
2023-05-15rework server-worker communicationEgor Tensin
OK, this is a major rework. * tcp_server: connection threads are not detached anymore, the caller has to clean them up. This was done so that the server can clean up the threads cleanly. * run_queue: simple refactoring, run_queue_entry is called just run now. * server: worker threads are now killed when a run is assigned to a worker. * worker: the connection to server is no longer persistent. A worker sends "new-worker", waits for a task, closes the connection, and when it's done, sends the "complete" message and waits for a new task. This is supposed to improve resilience, since the worker-server connections don't have to be maintained while the worker is doing a CI run.
2023-05-14command: adjust order of parameters to handlersEgor Tensin
2023-05-14msg: enforce at least one wordEgor Tensin
Also, move some stuff to net.c where it belongs.
2023-05-13command: refactoringEgor Tensin
2023-05-13best practices & coding style fixesEgor Tensin
* I don't really need to declare all variables at the top of the function anymore. * Default-initialize variables more. * Don't set the output parameter until the object is completely constructed.
2023-05-13add command module to handle request-response communicationsEgor Tensin