aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/src/event_loop.h (follow)
Commit message (Collapse)AuthorAge
* event_loop: add event_loop_add_onceEgor Tensin2023-06-13
|
* sanitize #include-sEgor Tensin2023-06-13
|
* event_loop: hide the API detailsEgor Tensin2023-06-13
|
* use signalfd to stop on SIGTERMEgor Tensin2023-06-13
Is this an overkill? I don't know. The thing is, correctly intercepting SIGTERM (also SIGINT, etc.) is incredibly tricky. For example, before this commit, my I/O loops in server.c and worker.c were inherently racy. This was immediately obvious if you tried to run the tests. The tests (especially the Valgrind flavour) would run a worker, wait until it prints a "Waiting for a new command" line, and try to kill it using SIGTERM. The problem is, the global_stop_flag check could have already been executed by the worker, and it would hang forever in recv(). The solution seems to be to use signalfd and select()/poll(). I've never used either before, but it seems to work well enough - at least the very same tests pass and don't hang now.