aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/src/server.c (unfollow)
Commit message (Collapse)Author
2023-07-07server: fix a possible leakEgor Tensin
2023-07-05tcp_server: keep track of client threadsEgor Tensin
This is a major change, obviously; brought to me by Valgrind, which noticed that we don't actually clean up after cimple-client threads. For a more thorough explanation, please see the added comment in tcp_server.c.
2023-07-04sanitize #include-sEgor Tensin
2023-07-04move custom message parsing to a separate moduleEgor Tensin
2023-07-04storage_sqlite: refactoringEgor Tensin
2023-07-04storage: mark completed runs as suchEgor Tensin
2023-07-04storage: requeue old runs from storage on startupEgor Tensin
2023-07-04tcp_server: always clean up connection descriptorsEgor Tensin
2023-07-04sqlite: store new runs in SQLiteEgor Tensin
2023-07-04storage_sqlite: refactoringEgor Tensin
2023-06-13minor refactoringEgor Tensin
2023-06-13signal: remove the stupid add_to_event_loop wrapperEgor Tensin
2023-06-13server: handle disconnected workers gracefullyEgor Tensin
2023-06-13signal: refactoringEgor Tensin
2023-06-13use signalfd to stop on SIGTERMEgor Tensin
Is this an overkill? I don't know. The thing is, correctly intercepting SIGTERM (also SIGINT, etc.) is incredibly tricky. For example, before this commit, my I/O loops in server.c and worker.c were inherently racy. This was immediately obvious if you tried to run the tests. The tests (especially the Valgrind flavour) would run a worker, wait until it prints a "Waiting for a new command" line, and try to kill it using SIGTERM. The problem is, the global_stop_flag check could have already been executed by the worker, and it would hang forever in recv(). The solution seems to be to use signalfd and select()/poll(). I've never used either before, but it seems to work well enough - at least the very same tests pass and don't hang now.
2023-06-11msg: rework some APIsEgor Tensin
2023-05-15signal: refactoringEgor Tensin
2023-05-15minor refactoringEgor Tensin
2023-05-15signal: refactoring, add comments in tcp_server, etc.Egor Tensin
2023-05-15EINVAL means EINTR also?Egor Tensin
2023-05-15rework server-worker communicationEgor Tensin
OK, this is a major rework. * tcp_server: connection threads are not detached anymore, the caller has to clean them up. This was done so that the server can clean up the threads cleanly. * run_queue: simple refactoring, run_queue_entry is called just run now. * server: worker threads are now killed when a run is assigned to a worker. * worker: the connection to server is no longer persistent. A worker sends "new-worker", waits for a task, closes the connection, and when it's done, sends the "complete" message and waits for a new task. This is supposed to improve resilience, since the worker-server connections don't have to be maintained while the worker is doing a CI run.
2023-05-14command: adjust order of parameters to handlersEgor Tensin
2023-05-14msg: add functions for one-off communicationEgor Tensin
2023-05-13ci_queue -> run_queueEgor Tensin
Also, some minor refactoring.
2023-05-13command: refactoringEgor Tensin
2023-05-13best practices & coding style fixesEgor Tensin
* I don't really need to declare all variables at the top of the function anymore. * Default-initialize variables more. * Don't set the output parameter until the object is completely constructed.
2023-05-13add command module to handle request-response communicationsEgor Tensin
2023-05-12ci_queue: rename a couple of functionsEgor Tensin
2023-05-06shut down server/workers gracefully on SIGTERMEgor Tensin
2023-05-06get rid of __attribute__((constructor))Egor Tensin
Explicit is better than implicit.
2023-04-29make struct ci_queue_entry opaqueEgor Tensin
2023-04-29make struct server opaqueEgor Tensin
2023-04-29make struct tcp_server opaqueEgor Tensin
2023-04-27fix a typoEgor Tensin
2023-04-27rename commandsEgor Tensin
2022-12-02add copyright noticesEgor Tensin
2022-09-11create SQLite database on startupEgor Tensin
2022-09-08log: refactoringEgor Tensin
2022-09-08sanitize #include-sEgor Tensin
2022-08-28update command namesEgor Tensin
2022-08-28server: notify workers about requeued jobsEgor Tensin
This allows free workers to pick up jobs after dead workers.
2022-08-28server: notify all threads about shutting downEgor Tensin
The problem is pthread_cond_destroy is unsafe to call if there're threads waiting in pthread_cond_wait. I'm not sure this fix is enough: what if the "broadcast" doesn't reach the threads until we call pthread_cond_destroy? Does it even work that way? Idk
2022-08-28make proper "error" messagesEgor Tensin
Previously, the client had no way to distinguish errors from succesful calls.
2022-08-28make compilers happierEgor Tensin
2022-08-28server: more loggingEgor Tensin
2022-08-28holy crap, it actually kinda works nowEgor Tensin
Previously, I had a stupid system where I would create a thread after every accept(), and put worker descriptors in a queue. A special "scheduler" thread would then pick them out, and give out jobs to complete. The problem was, of course, I couldn't conveniently poll job status from workers. I thought about using poll(), but that turned out to be a horribly complicated API. How do I deal with partial reads, for example? I don't honestly know. Then it hit me that I could just use the threads that handle accept()ed connections as "worker threads", which would synchronously schedule jobs and wait for them to complete. This solves every problem and removes the need for a lot of inter-thread synchronization magic. It even works now, holy crap! You can launch and terminate workers at will, and they will pick up new jobs automatically. As a side not, msg_recv_and_handle turned out to be too limiting and complicated for me, so I got rid of that, and do normal msg_recv/msg_send calls.
2022-08-28server: shutting down more gracefullyEgor Tensin
2022-08-26fix pthread error handlingEgor Tensin
pthread functions return positive error codes.
2022-08-26add some more codeEgor Tensin
This adds a basic "worker" program. You can now do something like ./server & ./worker & ./client ci_run URL REV and the server should pass a message to worker, after which it should clone the repository at URL, checkout REV, and try to run the CI script. It's extremely unfinished: I need to sort out the graceful shutdown, how the server manages workers, etc.
2022-08-25msg: refactoringEgor Tensin