Commit message (Collapse) | Author | ||
---|---|---|---|
2023-06-13 | signal: remove the stupid add_to_event_loop wrapper | Egor Tensin | |
2023-06-13 | signal: refactoring | Egor Tensin | |
2023-06-13 | signal: remove unused APIs | Egor Tensin | |
2023-06-13 | event_loop: hide the API details | Egor Tensin | |
2023-06-13 | use signalfd to stop on SIGTERM | Egor Tensin | |
Is this an overkill? I don't know. The thing is, correctly intercepting SIGTERM (also SIGINT, etc.) is incredibly tricky. For example, before this commit, my I/O loops in server.c and worker.c were inherently racy. This was immediately obvious if you tried to run the tests. The tests (especially the Valgrind flavour) would run a worker, wait until it prints a "Waiting for a new command" line, and try to kill it using SIGTERM. The problem is, the global_stop_flag check could have already been executed by the worker, and it would hang forever in recv(). The solution seems to be to use signalfd and select()/poll(). I've never used either before, but it seems to work well enough - at least the very same tests pass and don't hang now. | |||
2023-05-15 | signal: refactoring | Egor Tensin | |
2023-05-15 | signal: refactoring, add comments in tcp_server, etc. | Egor Tensin | |
2023-05-13 | use -std=c17 -Wpedantic | Egor Tensin | |
2023-05-06 | get rid of __attribute__((constructor)) | Egor Tensin | |
Explicit is better than implicit. | |||
2022-12-02 | add copyright notices | Egor Tensin | |
2022-08-28 | don't use the latest glibc features | Egor Tensin | |
pthread_attr_setsigmask_np is only available since 2.32, which is too modern. | |||
2022-08-28 | make compilers happier | Egor Tensin | |
2022-08-26 | worker: allow graceful shutdowns | Egor Tensin | |
Well, maybe "graceful" is a strong word, but now you _can_ do ./server & ./worker & ./client ci_run URL REV && kill "$( pidof worker )" and the worker will wait for the CI run to complete. |