aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/src/tcp_server.c (unfollow)
Commit message (Collapse)Author
2023-07-04tcp_server: always clean up connection descriptorsEgor Tensin
2023-06-30fix function names in error messagesEgor Tensin
2023-06-13signal: refactoringEgor Tensin
2023-06-13sanitize #include-sEgor Tensin
2023-06-13event_loop: hide the API detailsEgor Tensin
2023-06-13use signalfd to stop on SIGTERMEgor Tensin
Is this an overkill? I don't know. The thing is, correctly intercepting SIGTERM (also SIGINT, etc.) is incredibly tricky. For example, before this commit, my I/O loops in server.c and worker.c were inherently racy. This was immediately obvious if you tried to run the tests. The tests (especially the Valgrind flavour) would run a worker, wait until it prints a "Waiting for a new command" line, and try to kill it using SIGTERM. The problem is, the global_stop_flag check could have already been executed by the worker, and it would hang forever in recv(). The solution seems to be to use signalfd and select()/poll(). I've never used either before, but it seems to work well enough - at least the very same tests pass and don't hang now.
2023-06-09add {file,net}_close as a wrapper to close(2)Egor Tensin
2023-05-15signal: refactoringEgor Tensin
2023-05-15signal: refactoring, add comments in tcp_server, etc.Egor Tensin
2023-05-15rework server-worker communicationEgor Tensin
OK, this is a major rework. * tcp_server: connection threads are not detached anymore, the caller has to clean them up. This was done so that the server can clean up the threads cleanly. * run_queue: simple refactoring, run_queue_entry is called just run now. * server: worker threads are now killed when a run is assigned to a worker. * worker: the connection to server is no longer persistent. A worker sends "new-worker", waits for a task, closes the connection, and when it's done, sends the "complete" message and waits for a new task. This is supposed to improve resilience, since the worker-server connections don't have to be maintained while the worker is doing a CI run.
2023-05-13best practices & coding style fixesEgor Tensin
* I don't really need to declare all variables at the top of the function anymore. * Default-initialize variables more. * Don't set the output parameter until the object is completely constructed.
2023-04-29make struct tcp_server opaqueEgor Tensin
2022-12-02add copyright noticesEgor Tensin
2022-09-08log: refactoringEgor Tensin
2022-09-08sanitize #include-sEgor Tensin
2022-08-28don't use the latest glibc featuresEgor Tensin
pthread_attr_setsigmask_np is only available since 2.32, which is too modern.
2022-08-28server: shutting down more gracefullyEgor Tensin
2022-08-26add check_errno macroEgor Tensin
2022-08-26fix pthread error handlingEgor Tensin
pthread functions return positive error codes.
2022-08-25net: rework APIEgor Tensin
First, rename all API functions so that they start with net_. Second, abstract the basic TCP server functionality into tcp_server.c. This includes reworking net_accept so that it's a simple blocking operation, and putting the callback stuff to tcp_server.c. Also, the server now uses detached threads instead of fork(), since I want connection handlers to share memory.