aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/src (unfollow)
Commit message (Collapse)Author
2023-07-07clang-format: don't break string literalsEgor Tensin
2023-07-07test: add some basic command-line usage testsEgor Tensin
2023-07-07support code coverage report generationEgor Tensin
2023-07-07server: fix a possible leakEgor Tensin
2023-07-07sqlite: minor refactoringEgor Tensin
2023-07-06storage_sqlite: avoid races when inserting reposEgor Tensin
Insert first, then query the ID. That way, it'll work even if there're other workers inserting new repos.
2023-07-06cmake: fix Valgrind runs with Clang buildsEgor Tensin
2023-07-05worker: actually stay offlineEgor Tensin
I don't know what I was thinking, but contrary to my intention, the worker stayed connected to the server all the time.
2023-07-05tcp_server: minor refactoringEgor Tensin
2023-07-05tcp_server: close client connectionsEgor Tensin
I kinda forgot that I'm supposed to clean up client connections, and they immediately blew up in my face.
2023-07-05command: dedupe the codeEgor Tensin
2023-07-05tcp_server: keep track of client threadsEgor Tensin
This is a major change, obviously; brought to me by Valgrind, which noticed that we don't actually clean up after cimple-client threads. For a more thorough explanation, please see the added comment in tcp_server.c.
2023-07-04sanitize #include-sEgor Tensin
2023-07-04worker: close the leftover descriptorEgor Tensin
Thanks, Valgrind! As a note: if I think that Valgrind reports a false positive, chances are, it's not.
2023-07-04move custom message parsing to a separate moduleEgor Tensin
2023-07-04storage_sqlite: refactoringEgor Tensin
2023-07-04sqlite: rename a columnEgor Tensin
2023-07-04storage: mark completed runs as suchEgor Tensin
2023-07-04storage: requeue old runs from storage on startupEgor Tensin
2023-07-04tcp_server: always clean up connection descriptorsEgor Tensin
2023-07-04sqlite: store new runs in SQLiteEgor Tensin
2023-07-04storage_sqlite: refactoringEgor Tensin
2023-07-04sqlite: add run status fieldEgor Tensin
2023-07-04fix a compiler warningEgor Tensin
2023-07-04appease clang-formatEgor Tensin
2023-06-30use designated struct initializers moreEgor Tensin
2023-06-30show git hash with --versionEgor Tensin
Also, use cmake's configure_file to build string constants in.
2023-06-30fix function names in error messagesEgor Tensin
2023-06-30use __WNOTHREAD w/ waitpidEgor Tensin
I learned about this flag on my previous job; basically, it should be enabled by default IMO, so that the thread doesn't receive signals from other threads' children. Here, it doesn't matter too much, since we're waiting for a specific child. However, if we were to use waitpid(-1, ...), it would be essential to use this flag. Still, even here, it's good to have this on.
2023-06-28log: minor refactoringEgor Tensin
2023-06-28process: fix function name in logsEgor Tensin
2023-06-28ci: environment array to execvpe must be NULL-terminatedEgor Tensin
Thanks, Valgrind.
2023-06-28log: support logging levelsEgor Tensin
2023-06-28test: skip ci.sh w/ ValgrindEgor Tensin
2023-06-28valgrind: exit with an error after leak detectionEgor Tensin
I cannot believe this isn't default.
2023-06-28file: readlink(2) doesn't null-terminateEgor Tensin
Thanks, valgrind.
2023-06-14minor refactoringEgor Tensin
2023-06-13cmake: fix grammar in option descriptionEgor Tensin
2023-06-13cmake: why the hell would I need MSVC optionsEgor Tensin
2023-06-13minor refactoringEgor Tensin
2023-06-13signal: remove the stupid add_to_event_loop wrapperEgor Tensin
2023-06-13server: handle disconnected workers gracefullyEgor Tensin
2023-06-13event_loop: support more event typesEgor Tensin
2023-06-13event_loop: add event_loop_add_onceEgor Tensin
2023-06-13signal: sigprocmask -> pthread_sigmaskEgor Tensin
2023-06-13signal: refactoringEgor Tensin
2023-06-13sanitize #include-sEgor Tensin
2023-06-13signal: remove unused APIsEgor Tensin
2023-06-13event_loop: hide the API detailsEgor Tensin
2023-06-13use signalfd to stop on SIGTERMEgor Tensin
Is this an overkill? I don't know. The thing is, correctly intercepting SIGTERM (also SIGINT, etc.) is incredibly tricky. For example, before this commit, my I/O loops in server.c and worker.c were inherently racy. This was immediately obvious if you tried to run the tests. The tests (especially the Valgrind flavour) would run a worker, wait until it prints a "Waiting for a new command" line, and try to kill it using SIGTERM. The problem is, the global_stop_flag check could have already been executed by the worker, and it would hang forever in recv(). The solution seems to be to use signalfd and select()/poll(). I've never used either before, but it seems to work well enough - at least the very same tests pass and don't hang now.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-22 13:27:27 +0000