From 97b930c6edc7973497f469ae859fa2258cbea4d6 Mon Sep 17 00:00:00 2001 From: Egor Tensin Date: Sun, 20 Aug 2023 18:38:17 +0200 Subject: use variables instead facts mostly everywhere set_fact is stupid; they persist through multiple role executions; for example, you cannot do this: set_fact: foo: '{{ foo | default("bar") }}' If somebody calls the role and defines foo, it will always be set to that value forever, even for subsequent role calls. --- roles/digitalocean_volume/tasks/main.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'roles/digitalocean_volume') diff --git a/roles/digitalocean_volume/tasks/main.yml b/roles/digitalocean_volume/tasks/main.yml index c23da76..07d6c74 100644 --- a/roles/digitalocean_volume/tasks/main.yml +++ b/roles/digitalocean_volume/tasks/main.yml @@ -1,11 +1,7 @@ -- name: Set default mount point - ansible.builtin.set_fact: - volume_dir: "{{ volume_dir | default('/mnt/{{ volume_name }}') }}" - - name: 'Mount volume: {{ volume_name }}' become: true ansible.posix.mount: - path: '{{ volume_dir }}' + path: "{{ volume_dir | default('/mnt/{{ volume_name }}') }}" src: '/dev/disk/by-id/scsi-0DO_Volume_{{ volume_name }}' state: mounted fstype: '{{ volume_fs }}' -- cgit v1.2.3