From de0a57525994b25bbefa892a46ea3955c35341ab Mon Sep 17 00:00:00 2001 From: Egor Tensin Date: Wed, 25 Jan 2023 12:03:30 +0100 Subject: linting --- roles/apt/tasks/main.yml | 12 ++++++------ roles/common/handlers/main.yml | 2 +- roles/docker/tasks/main.yml | 16 ++++++++-------- roles/etckeeper/tasks/main.yml | 2 +- roles/flatpak/tasks/main.yml | 6 +++--- roles/pacman/tasks/main.yml | 22 +++++++++++----------- roles/snap/tasks/main.yml | 14 +++++++------- roles/vagrant/tasks/main.yml | 6 +++--- roles/yay/tasks/main.yml | 10 +++++----- 9 files changed, 45 insertions(+), 45 deletions(-) diff --git a/roles/apt/tasks/main.yml b/roles/apt/tasks/main.yml index 5a33688..f331995 100644 --- a/roles/apt/tasks/main.yml +++ b/roles/apt/tasks/main.yml @@ -1,15 +1,15 @@ - name: Check if apt is installed command: apt-get --version register: apt_version - changed_when: no - failed_when: no + changed_when: false + failed_when: false - when: apt_version.rc == 0 - become: yes + become: true block: - name: Upgrade packages apt: - update_cache: yes + update_cache: true upgrade: full notify: reboot @@ -18,8 +18,8 @@ - name: Clean up dependencies apt: - autoremove: yes - purge: yes + autoremove: true + purge: true notify: reboot - name: Flush handlers diff --git a/roles/common/handlers/main.yml b/roles/common/handlers/main.yml index 9560068..f569bd6 100644 --- a/roles/common/handlers/main.yml +++ b/roles/common/handlers/main.yml @@ -11,7 +11,7 @@ reboot_timeout: 300 # Don't reboot yourself accidentally: when: 'ansible_env["SSH_CLIENT"].split()[0] not in ansible_all_ipv4_addresses' - become: yes + become: true listen: reboot - name: Wait for connectivity diff --git a/roles/docker/tasks/main.yml b/roles/docker/tasks/main.yml index 71e13de..eddc811 100644 --- a/roles/docker/tasks/main.yml +++ b/roles/docker/tasks/main.yml @@ -1,19 +1,19 @@ - name: Check if Docker is installed command: docker --version register: docker_version - changed_when: no - failed_when: no + changed_when: false + failed_when: false - name: Clean up Docker data - become: yes + become: true command: docker system prune -a -f --volumes # Broken after a Docker upgrade: #community.docker.docker_prune: - # containers: yes - # images: yes + # containers: true + # images: true # images_filters: # dangling: false - # networks: yes - # volumes: yes - # builder_cache: yes + # networks: true + # volumes: true + # builder_cache: true when: docker_version.rc == 0 diff --git a/roles/etckeeper/tasks/main.yml b/roles/etckeeper/tasks/main.yml index d6acf24..3e37ed1 100644 --- a/roles/etckeeper/tasks/main.yml +++ b/roles/etckeeper/tasks/main.yml @@ -1,4 +1,4 @@ -- become: yes +- become: true block: - name: Check if /etc is versioned stat: diff --git a/roles/flatpak/tasks/main.yml b/roles/flatpak/tasks/main.yml index 37b301e..3fb28c3 100644 --- a/roles/flatpak/tasks/main.yml +++ b/roles/flatpak/tasks/main.yml @@ -1,10 +1,10 @@ - name: Check if flatpak is installed command: flatpak --version register: flatpak_version - changed_when: no - failed_when: no + changed_when: false + failed_when: false - when: flatpak_version.rc == 0 name: Upgrade packages command: flatpak update --noninteractive - become: yes + become: true diff --git a/roles/pacman/tasks/main.yml b/roles/pacman/tasks/main.yml index bbcdddc..acd2d31 100644 --- a/roles/pacman/tasks/main.yml +++ b/roles/pacman/tasks/main.yml @@ -1,16 +1,16 @@ - name: Check if pacman is installed command: pacman --version register: pacman_version - changed_when: no - failed_when: no + changed_when: false + failed_when: false - when: pacman_version.rc == 0 - become: yes + become: true block: - name: Upgrade packages community.general.pacman: - update_cache: yes - upgrade: yes + update_cache: true + upgrade: true register: pacman_result notify: reboot @@ -30,8 +30,8 @@ args: chdir: /etc register: git_status - changed_when: no - failed_when: no + changed_when: false + failed_when: false - fail: msg: Upgrading packages failed for an unknown reason! @@ -42,8 +42,8 @@ args: chdir: /etc register: only_gnupg - changed_when: no - failed_when: no + changed_when: false + failed_when: false - name: Commit changes in /etc command: | @@ -52,8 +52,8 @@ - name: Upgrade packages after GPG keys community.general.pacman: - update_cache: yes - upgrade: yes + update_cache: true + upgrade: true register: pacman_result notify: reboot diff --git a/roles/snap/tasks/main.yml b/roles/snap/tasks/main.yml index 007dbbe..5cb2fd2 100644 --- a/roles/snap/tasks/main.yml +++ b/roles/snap/tasks/main.yml @@ -1,10 +1,10 @@ - name: Check if snap is installed command: snap --version register: snap_version - changed_when: no - failed_when: no + changed_when: false + failed_when: false -- become: yes +- become: true when: snap_version.rc == 0 and etc_versioned block: - name: Check for changes in /etc @@ -12,16 +12,16 @@ args: chdir: /etc register: git_status - changed_when: no - failed_when: no + changed_when: false + failed_when: false - name: All changes in /etc are snap changes? shell: git status --porcelain=v1 | cut -c 4- | grep -G -v '^systemd/system/' | grep -G -v '/snap\.\|snap-' args: chdir: /etc register: only_snap - changed_when: no - failed_when: no + changed_when: false + failed_when: false - name: Commit changes in /etc command: etckeeper commit 'after snap run' diff --git a/roles/vagrant/tasks/main.yml b/roles/vagrant/tasks/main.yml index 800c1a2..31bfe11 100644 --- a/roles/vagrant/tasks/main.yml +++ b/roles/vagrant/tasks/main.yml @@ -1,8 +1,8 @@ - name: Check if vagrant is installed command: vagrant --version register: vagrant_version - changed_when: no - failed_when: no + changed_when: false + failed_when: false - when: vagrant_version.rc == 0 block: @@ -11,7 +11,7 @@ - name: Prune invalid entries command: vagrant global-status --prune - become: yes + become: true - name: Clean up boxes command: vagrant box prune --force --keep-active-boxes diff --git a/roles/yay/tasks/main.yml b/roles/yay/tasks/main.yml index 49356c7..a8a1c70 100644 --- a/roles/yay/tasks/main.yml +++ b/roles/yay/tasks/main.yml @@ -1,17 +1,17 @@ - name: Check if yay is installed command: yay --version register: yay_version - changed_when: no - failed_when: no + changed_when: false + failed_when: false - when: yay_version.rc == 0 block: - name: Upgrade packages kewlfft.aur.aur: use: yay - update_cache: yes - upgrade: yes - aur_only: yes + update_cache: true + upgrade: true + aur_only: true register: yay_result notify: reboot -- cgit v1.2.3