From 18f6b342764fb32dc91c539c3b507091f285d906 Mon Sep 17 00:00:00 2001 From: Egor Tensin Date: Sun, 1 Mar 2020 00:44:27 +0300 Subject: Makefile: code style --- Makefile | 31 +++++++++++++++++++++++-------- 1 file changed, 23 insertions(+), 8 deletions(-) (limited to 'Makefile') diff --git a/Makefile b/Makefile index c8ee706..3cf3086 100644 --- a/Makefile +++ b/Makefile @@ -7,7 +7,7 @@ SHELL := bash .DEFAULT_GOAL := all .SUFFIXES: -PROJECT := math_server +PROJECT := math-server # Enable buildx support: export DOCKER_CLI_EXPERIMENTAL := enabled # Target platforms (used by buildx): @@ -15,42 +15,54 @@ platforms := linux/amd64,linux/armhf # Docker Hub credentials: DOCKER_USERNAME := egortensin +.PHONY: all all: build +.PHONY: DO DO: +.PHONY: login login: ifndef DOCKER_PASSWORD $(error Please define DOCKER_PASSWORD) endif @echo "$(DOCKER_PASSWORD)" | docker login --username "$(DOCKER_USERNAME)" --password-stdin +.PHONY: build # Build natively by default. build: compose/build +.PHONY: clean clean: docker system prune --all --force --volumes +.PHONY: push # Push multi-arch images by default. push: buildx/push +.PHONY: pull pull: docker-compose pull +.PHONY: up up: docker-compose up -d server +.PHONY: client client: docker-compose run --rm client +.PHONY: down down: docker-compose down --volumes +.PHONY: check-build check-build: ifndef FORCE $(warning Going to build natively; consider `docker buildx build` instead) endif +.PHONY: check-push check-push: ifndef FORCE $(error Please use `docker buildx build --push` instead) @@ -62,6 +74,7 @@ endif docker/build/%: DO check-build docker build -f "$*/Dockerfile" -t "$(DOCKER_USERNAME)/math-$*" . +.PHONY: docker/build docker/build: docker/build/client docker/build/server # `docker push` would replace the multiarch repo with a single image by default @@ -70,40 +83,42 @@ docker/build: docker/build/client docker/build/server docker/push/%: DO check-push docker/build/% docker push "$(DOCKER_USERNAME)/math-$*" +.PHONY: docker/push docker/push: check-push docker/push/client docker/push/server +.PHONY: compose/build # `docker-compose build` has the same problems as `docker build`. compose/build: check-build docker-compose build +.PHONY: compose/push # `docker-compose push` has the same problems as `docker push`. compose/push: check-push compose/build docker-compose push # The simple way to build multiarch repos is `docker buildx`. -# Re-register binfmt_misc formats with the F flag (required i.e. on Bionic): +.PHONY: fix-binfmt +# Re-register binfmt_misc formats with the F flag (required e.g. on Bionic): fix-binfmt: docker run --rm --privileged docker/binfmt:66f9012c56a8316f9244ffd7622d7c21c1f6f28d +.PHONY: buildx/create buildx/create: fix-binfmt docker buildx create --use --name "$(PROJECT)_builder" +.PHONY: buildx/rm buildx/rm: docker buildx rm "$(PROJECT)_builder" buildx/build/%: DO docker buildx build -f "$*/Dockerfile" -t "$(DOCKER_USERNAME)/math-$*" --platform "$(platforms)" --progress plain . +.PHONY: buildx/build buildx/build: buildx/build/client buildx/build/server buildx/push/%: DO docker buildx build -f "$*/Dockerfile" -t "$(DOCKER_USERNAME)/math-$*" --platform "$(platforms)" --progress plain --push . +.PHONY: buildx/push buildx/push: buildx/push/client buildx/push/server - -.PHONY: all login build clean push pull up client down -.PHONY: check-build check-push -.PHONY: docker/build docker/push -.PHONY: compose/build compose/push -.PHONY: fix-binfmt buildx/create buildx/rm buildx/build buildx/push -- cgit v1.2.3