From cdf542502879ef992efa59dce788e703dd978578 Mon Sep 17 00:00:00 2001 From: Egor Tensin Date: Sun, 29 Nov 2020 21:10:29 +0300 Subject: clarify dependency version bounds --- constraints.txt | 10 ++++++++-- requirements.txt | 1 + 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/constraints.txt b/constraints.txt index 8a74c51..04e6c11 100644 --- a/constraints.txt +++ b/constraints.txt @@ -1,3 +1,9 @@ -# Numpy 1.17 dropped support for Python 3.4. -numpy >1.11,<1.17 ; python_version == '3.4' +# matplotlib 1.5 is one of the versions that works with Python 3.4, and it +# doesn't specify the upper bound for its numpy dependency. So pip will try to +# install the latest version, which doesn't work with 3.4. Putting the numpy +# and the matplotlib requirements to the same requirements.txt file doesn't +# work unfortunately, the latest version will still get picked up. + +# The lower bound is random, 1.16 is the latest version to support 3.4. +numpy >=1.11,<1.17 ; python_version == '3.4' numpy >=1.17 ; python_version > '3.4' diff --git a/requirements.txt b/requirements.txt index 0e97461..9e942a5 100644 --- a/requirements.txt +++ b/requirements.txt @@ -1,3 +1,4 @@ +# Some random known-to-work versions. matplotlib ~=1.5 ; python_version == '3.4' matplotlib ~=2.1 ; python_version == '3.5' matplotlib ~=3.1 ; python_version > '3.5' -- cgit v1.2.3