From 7d12c90b969f22d54f7b11569c4c789f8f2bd0e2 Mon Sep 17 00:00:00 2001 From: Egor Tensin Date: Thu, 10 Mar 2022 11:24:18 +0500 Subject: Makefile: minor best practices fixes --- Makefile | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/Makefile b/Makefile index ece80b3..7d2d4a1 100644 --- a/Makefile +++ b/Makefile @@ -1,6 +1,3 @@ -# Various one-liners which I'm too lazy to remember. -# Basically a collection of really small shell scripts. - MAKEFLAGS += --no-builtin-rules --no-builtin-variables --warn-undefined-variables unexport MAKEFLAGS .DEFAULT_GOAL := all @@ -9,9 +6,6 @@ unexport MAKEFLAGS SHELL := bash .SHELLFLAGS := -eu -o pipefail -c -.PHONY: DO -DO: - escape = $(subst ','\'',$(1)) define noexpand @@ -49,6 +43,9 @@ $(eval $(call noexpand,BOOST_VERSION)) $(eval $(call noexpand,CMAKE_FLAGS)) $(eval $(call noexpand,DESTDIR)) +.PHONY: DO +DO: + .PHONY: all all: build @@ -90,7 +87,7 @@ docs: cmake --build '$(call escape,$(cmake_dir))' --target docs ifndef CI ifdef xdg-open - xdg-open '$(call escape,$(cmake_dir))/html/index.html' + xdg-open '$(call escape,$(cmake_dir))/html/index.html' &> /dev/null endif endif -- cgit v1.2.3